[PATCH] D129104: [Modules] Add ODR Check for concepts

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu marked an inline comment as done.
ChuanqiXu added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:6533
+      const Expr *YCE = ConceptY->getConstraintExpr();
+      assert(XCE && YCE && "ConceptDecl without constraint expression?");
+      llvm::FoldingSetNodeID XID, YID;
----------------
The assertion here should be fine since the '=' part is guaranteed by std: https://eel.is/c++draft/temp.concept#1 and clang would reject it too: https://godbolt.org/z/Tfe493xK7


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129104/new/

https://reviews.llvm.org/D129104