[PATCH] D129104: [Modules] Add ODR Check for concepts

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:6532
+      const Expr *XCE = ConceptX->getConstraintExpr();
+      const Expr *YCE = ConceptY->getConstraintExpr();
+      assert(XCE && YCE && "ConceptDecl wihtout constraint expression?");
----------------
erichkeane wrote:
> This isn't necessarily valid here, you did a dyn_cast above.
Oh, my bad. I should use `cast`. We could find the style at line 6525-6526 and line 6519-6520.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129104/new/

https://reviews.llvm.org/D129104