[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

I think this can be pushed now. You need to remove the variable

> In file included from /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/MC/ELFObjectWriter.cpp:41:
> /var/lib/buildkite-agent/builds/llvm-project/llvm/include/llvm/Support/Compression.h:27:30: error: constexpr variable cannot have non-literal type 'const std::string' (aka 'const basic_string<char>')
> static constexpr std::string AlgorithmName = "zlib";

You likely need to run `ninja check-llvm check-clang check-clang-tools check-lld check-lldb` to ensure all relevant targets still build.
(You can use `check-all` if your lists of LLVM_ENABLED_PROJECTS/LLVM_ENABLE_RUNTIMES are appropriate.)



================
Comment at: llvm/include/llvm/Support/Compression.h:48
+} // End of namespace zlib
+
+} // End of namespace compression
----------------
No need to add blank line between two namespace `}`.


================
Comment at: llvm/lib/Support/Compression.cpp:25
 using namespace llvm;
 
+using namespace llvm::compression;
----------------
delete the excess blank line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128953/new/

https://reviews.llvm.org/D128953