[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

[Cole Kissane via Phabricator via cfe-commits]

ckissane added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:27
 
+static constexpr std::string AlgorithmName = "zlib";
 static constexpr int NoCompression = 0;
----------------
MaskRay wrote:
> Is it still used?
> 
> Prefer StringRef if the string is backed from some storage.
No it is not, I will remove it and reintroduce it in the first patch that adds zstd


================
Comment at: llvm/unittests/Support/CompressionTest.cpp:21
 using namespace llvm;
 
+using namespace llvm::compression;
----------------
MaskRay wrote:
> Delete blank line between two `using`
will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128953/new/

https://reviews.llvm.org/D128953