[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

[Prabhdeep Soni via Phabricator via cfe-commits]

psoni2628 added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608
+  ///
+  /// \param DL      Debug location for instructions added by unrolling.
+  /// \param Loop    The simd loop.
----------------
jdoerfert wrote:
> psoni2628 wrote:
> > jdoerfert wrote:
> > > No debug location needed. You also copied the comment that makes little sene.
> > It isn't used in the original applySimd either. Should I remove it in both places?
> Yes.
Looks like I'll need to fix `applySimd` on the MLIR side too. I think it makes more sense to do that separately in a different patch. For now, I will leave `applySimd` with the unused `DebugLocation`. I will fix `applySimdlen`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129149/new/

https://reviews.llvm.org/D129149