[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 6 09:07:38 PDT 2022


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608
+  ///
+  /// \param DL      Debug location for instructions added by unrolling.
+  /// \param Loop    The simd loop.
----------------
psoni2628 wrote:
> jdoerfert wrote:
> > No debug location needed. You also copied the comment that makes little sene.
> It isn't used in the original applySimd either. Should I remove it in both places?
Yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129149/new/

https://reviews.llvm.org/D129149



More information about the cfe-commits mailing list