[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Fri Jul 1 14:59:13 PDT 2022

vitalybuka reopened this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

In D126907#3623377 <https://reviews.llvm.org/D126907#3623377>, @vitalybuka wrote:

> FYI. The same on a different bot https://lab.llvm.org/buildbot/#/builders/5/builds/25486/steps/19/logs/stdio

Not sure if the URL above was not related, as lease I see no red builds after "relanded patch"

However these are 100% relevant, I tested msan one locally 258c3aee54e1 <https://reviews.llvm.org/rG258c3aee54e11bc5c5d8ac137eb15e8d5bbcc7e4> vs 188582b7e0f3 <https://reviews.llvm.org/rG188582b7e0f357bb9b137b995f773d114472a9c4>
https://lab.llvm.org/buildbot/#/builders/74/builds/11706
https://lab.llvm.org/buildbot/#/builders/85/builds/8938
https://lab.llvm.org/buildbot/#/builders/168/builds/7114

However sanitizers has nothing to do with the problems, you just need compilers builds with asserts, and then use that one to build and run libcxx tests.

This reproduces the issue on 188582b7e0f357bb9b137b995f773d114472a9c4 <https://reviews.llvm.org/rG188582b7e0f357bb9b137b995f773d114472a9c4>

  mkdir b0
  cd b0/
  # ${HOME}/src/clang/bin/clang++ is some stable good build of clang.
  cmake -GNinja ${HOME}/src/llvm.git/llvm-project/llvm '-DLLVM_ENABLE_PROJECTS=clang;lld'   -DLLVM_CCACHE_BUILD=ON -DCMAKE_C_COMPILER=${HOME}/src/clang/bin/clang -DCMAKE_CXX_COMPILER=${HOME}/src/clang/bin/clang++  -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON
  ninja

  mkdir ../b1
  cd ../b1
  cmake -GNinja ${HOME}/src/llvm.git/llvm-project/llvm '-DLLVM_ENABLE_PROJECTS=libcxx;libcxxabi'  -DCMAKE_C_COMPILER=$(readlink -f ../b0)/bin/clang -DCMAKE_CXX_COMPILER=$(readlink -f ../b0)/bin/clang++  -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON
  ninja check-cxx

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907