[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 13:14:34 PDT 2022


erichkeane added a comment.

Crash that required the revert : https://reviews.llvm.org/rGbefa8cf087dbb8159a4d9dc8fa4d6748d6d5049a

reduces to :

   template<class _Ip>
   concept sentinel_for =
     requires(_Ip __i) {
       __i++;
     };
  
   template<class _Ip>
   concept bidirectional_iterator =
     sentinel_for<_Ip>;
  
   
  template <class _Iter>
  class move_iterator
  {
  public:
      auto operator++(int)
          requires
          sentinel_for<_Iter>;
  };
   
  static_assert( bidirectional_iterator<move_iterator<int>>);

In other news, I discovered that 'check-all' and 'stage2-check-all' doesn't include 'check-runtimes', which managed to be why I missed this :/

I won't have time to poke that this until Tuesday since Monday is a US holiday and I'm done for the day, so if @ChuanqiXu or others wish to mess with this, feel free, otherwise I'll get back on it next week!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907



More information about the cfe-commits mailing list