[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

Thu Jun 30 06:23:15 PDT 2022

anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54
+
+  // Set alias for "riscv{64|32}-unknown-unknown-elf"
+  SmallVector<std::string, 1> TripleAliases;
----------------
arichardson wrote:
> This seems like the wrong place to add this workaround, shouldn't the change be in `GCCInstallation::init`? That way targets other than RISC-V also benefit from this fix.
> 
`GCCInstallation` knows nothing about triple equivalence of the specific targets, but provides `TripleAliases` init variable for installation target callers. Other targets are to do the same initialization as we do here in case of different normalized and layout-used triple names.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128625/new/

https://reviews.llvm.org/D128625