[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 30 03:03:53 PDT 2022


arichardson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54
+
+  // Set alias for "riscv{64|32}-unknown-unknown-elf"
+  SmallVector<std::string, 1> TripleAliases;
----------------
This seems like the wrong place to add this workaround, shouldn't the change be in `GCCInstallation::init`? That way targets other than RISC-V also benefit from this fix.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128625/new/

https://reviews.llvm.org/D128625



More information about the cfe-commits mailing list