[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up
Phoebe Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 29 23:55:14 PDT 2022
pengfei added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:357
+ // Turn on _float16 for x86 (feature sse2)
+ HasFloat16 = SSELevel >= SSE2;
> MaskRay wrote:
> > `_Float16`
> > `for x86` convey no extra information since this file is for x86.
> Thinking again: The comment just repeats what the code does. So it can be deleted.
Yeah, I had the same feeling when updating. Will delete, thanks! :)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits