[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 23:52:43 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:357
 
+    // Turn on _float16 for x86 (feature sse2)
+    HasFloat16 = SSELevel >= SSE2;
----------------
MaskRay wrote:
> `_Float16`
> 
> `for x86` convey no extra information since this file is for x86.
Thinking again: The comment just repeats what the code does. So it can be deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128571/new/

https://reviews.llvm.org/D128571



More information about the cfe-commits mailing list