[PATCH] D128612: RISC-V big-endian support implementation

Guy Benyei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 02:21:36 PDT 2022

gbenyei added a comment.

In D128612#3617955 <https://reviews.llvm.org/D128612#3617955>, @MaskRay wrote:

> lld/ELF change should be dropped from this change. Don't use `config->endianness`.
> I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-)

Hi, I'm not sure I get it. How will we have a fully functional toolchain, if I don't implement the lld/ELF part?
In LLVM, unlike in GCC, target related decisions happen in runtime. I think it's a high level design decision. While I can understand the pain of LE developers getting a slightly slower linker due to endianness checking, I sure will feel the pain of a BE developer not having a linker...

Please explain why I shouldn't use `config->endianness`?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list