[PATCH] D128645: Update developer policy.

Edd Barrett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 29 01:00:47 PDT 2022

vext01 added inline comments.

Comment at: llvm/docs/DeveloperPolicy.rst:88
+#. Patches should be unified diffs with "infinite context" (i.e. using something
+   like `git diff -U999999 main`).
hubert.reinterpretcast wrote:
> Using `git diff` like this, there are risks that `main` is now ahead of your branch's base. Probably safer to use `HEAD~n` where `n` is the number of commits you have on your branch.
The exact command you want to issue is going to vary according to circumstance and personal workflow preference. Sometimes `main` is fine, if it isn't `HEAD~n` is fine, but if you have a lot of commits then determining (i.e. manually counting) `n` will be impractical and you probably want to just use an absolute git hash.

I don't think we need to delve into a great level of detail. I think the prose "using something like" is adequate.



More information about the cfe-commits mailing list