[PATCH] D128645: Update developer policy.

Edd Barrett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 27 09:16:36 PDT 2022

vext01 added inline comments.

Comment at: llvm/docs/DeveloperPolicy.rst:87-91
-#. Patches should be made with ``git format-patch``, or similar (see special
-   commands for `Requesting Phabricator review via the web interface
-   <Phabricator.html#phabricator-request-review-web>`_ ). If you use a
-   different tool, make sure it uses the ``diff -u`` format and that it
-   doesn't contain clutter which makes it hard to read.
aaron.ballman wrote:
> Changing this would require an RFC to see if the community wants to get rid of our requirement that patches be formatted. Personally, I'd be opposed to such a change; I think this should be kept.
Is there confusion between `git format-patch` and `git clang-format` here?

To be clear, I'm not proposing that the source code you change isn't syntactically formatted. But `git format-patch` does not do syntactic formatting, it just writes a diff to disk.

I don't think it matters how you generate your diff, but your changes need to have gone through `git clang-format` as described elsewhere in the llvm docs.



More information about the cfe-commits mailing list