[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 23 00:25:43 PDT 2022


ChuanqiXu added a comment.

In D128328#3603940 <https://reviews.llvm.org/D128328#3603940>, @iains wrote:

> In D128328#3602646 <https://reviews.llvm.org/D128328#3602646>, @iains wrote:
>
>> In D128328#3601080 <https://reviews.llvm.org/D128328#3601080>, @ChuanqiXu wrote:
>>
>>> It looks like we need to handle inline variable as well to match the intention.
>>
>> can you construct a test-case, where this would apply and which is not already diagnosed as incorrect?
>
> Did you have some ideas here?

The test may be something like:

  export module A;
  inline int a;
  module :private
  int a = 0; // expected-error 

But I feel like we couldn't  go on before we get response from WG21.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128328/new/

https://reviews.llvm.org/D128328



More information about the cfe-commits mailing list