[PATCH] D126291: [flang][Driver] Update link job on windows

Fri Jun 17 01:05:56 PDT 2022

rovka added a comment.

I'm going to go ahead and commit this on Monday if nobody raises any objections until then. Thanks again to everyone for all the help & feedback!

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773
+  // TODO: Make this work unconditionally once Flang is mature enough.
+  if (!Args.hasArg(options::OPT_flang_experimental_exec))
+    return;
----------------
mstorsjo wrote:
> Don't you need to have the same check in `addFortranRuntimeLibs` above too? As both of these functions are called without checking the condition in the caller.
I'd rather not, since that would require adding the `ArgList` as an input to `addFortranRuntimeLibs`. I don't think it's worth changing the interface just for the sake of something temporary. The whole point of checking the flag inside `addFortranRuntimeLibraryPath` is to make it really easy to remove the check later, without having to update all the callsites.

See also [[ https://reviews.llvm.org/D126291#inline-1227536:~:text=this%20flag%20is%20here%20only%20temporarily | the previous discussion ]] (I don't know how to get a link to a comment in Phab, so I just linked some text inside it).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291