[PATCH] D126291: [flang][Driver] Update link job on windows
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 16 14:13:02 PDT 2022
mstorsjo added a comment.
Looks good to me in general, one general question though.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773
+ // TODO: Make this work unconditionally once Flang is mature enough.
+ if (!Args.hasArg(options::OPT_flang_experimental_exec))
+ return;
----------------
Don't you need to have the same check in `addFortranRuntimeLibs` above too? As both of these functions are called without checking the condition in the caller.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126291/new/
https://reviews.llvm.org/D126291
More information about the cfe-commits
mailing list