[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

[David Tenty via Phabricator via cfe-commits]

daltenty marked an inline comment as done.
daltenty added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228
       GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass);
-    else if (D->hasAttr<DLLExportAttr>() && !GV->isDeclarationForLinker())
+    else if ((D->hasAttr<DLLExportAttr>() ||
+              shouldMapVisibilityToDLLExport(D)) &&
----------------
MaskRay wrote:
> Restrict this to AIX/XCOFF.
> 
> Really other binary format users will not need this.
I believe this is now done, via us now doing an early check on the setting of the LangOpt (which will always be `None` on non-AIX). No need for an extra check on the binary format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126340/new/

https://reviews.llvm.org/D126340