[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping
David Tenty via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 9 10:50:41 PDT 2022
daltenty updated this revision to Diff 435609.
daltenty added a comment.
- Don't try to export internal linkage RTTI types
- Make shouldMapVisibilityToDLLExport inline and provide a short-circuit evaluation in the case where no mapping is in effect. This should hopefully solve the compile time issues and asserts we are seeing on other platforms, as if the option isn't in effect we don't try to do any additional linkage computations over what we would normally do. Tested via profiling building tramp3d-v4 and our calls to the linkage computer fall back to what we were getting before this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126340/new/
https://reviews.llvm.org/D126340
Files:
clang/docs/UsersManual.rst
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/Options.td
clang/lib/CodeGen/CodeGenModule.cpp
clang/lib/CodeGen/CodeGenModule.h
clang/lib/CodeGen/ItaniumCXXABI.cpp
clang/lib/CodeGen/MicrosoftCXXABI.cpp
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/CodeGen/mdefault-visibility-export-mapping.c
clang/test/CodeGenCXX/mdefault-visibility-export-mapping-alias.cpp
clang/test/CodeGenCXX/mdefault-visibility-export-mapping-rtti.cpp
clang/test/CodeGenCXX/mdefault-visibility-export-mapping.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126340.435609.patch
Type: text/x-patch
Size: 40338 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220609/db800eaa/attachment-0001.bin>
More information about the cfe-commits
mailing list