[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

[Timm Bäder via Phabricator via cfe-commits]

tbaeder marked 2 inline comments as done.
tbaeder added inline comments.


================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:647
+    std::unique_ptr<Compilation> C(
+        TheDriver.BuildCompilation({"--gcc-toolchain="}));
+    ASSERT_TRUE(C);
----------------
ebevhan wrote:
> There's a binary name missing here:
> 
> ```
> {"clang", "--gcc-toolchain="}
> ```
> 
> Driver strips the first argument, so the behavior of this test becomes dependent on GCC_INSTALL_PREFIX which can cause it to fail in some cases.
Thanks, I pushed a commit adding the driver name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125862/new/

https://reviews.llvm.org/D125862