[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

[Bevin Hansson via Phabricator via cfe-commits]

ebevhan added a comment.

Hi! This test is failing in some of our downstream builds.



================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:647
+    std::unique_ptr<Compilation> C(
+        TheDriver.BuildCompilation({"--gcc-toolchain="}));
+    ASSERT_TRUE(C);
----------------
There's a binary name missing here:

```
{"clang", "--gcc-toolchain="}
```

Driver strips the first argument, so the behavior of this test becomes dependent on GCC_INSTALL_PREFIX which can cause it to fail in some cases.


================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:687
+    std::unique_ptr<Compilation> C(
+        TheDriver.BuildCompilation({"--gcc-toolchain="}));
+    ASSERT_TRUE(C);
----------------
Here too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125862/new/

https://reviews.llvm.org/D125862