[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

Ryan Prichard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 8 15:49:47 PDT 2022


rprichard added a comment.

In D127267#3568388 <https://reviews.llvm.org/D127267#3568388>, @rprichard wrote:

> Aside: There are only two calls to AllocateTarget: one in TargetInfo::CreateTargetInfo and one in NVPTXTargetInfo::NVPTXTargetInfo. This change removes NVPTXTargetInfo's call.

There are various places that call clang::TargetInfo::CreateTargetInfo, though, so if a call site had been providing a clang::TargetOptions with a set HostTriple field, but not calling clang::TargetInfo::setAuxTarget, then maybe the NVPTXTargetInfo behavior could change. I'll audit the calls of clang::TargetInfo::CreateTargetInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127267/new/

https://reviews.llvm.org/D127267



More information about the cfe-commits mailing list