[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

Ryan Prichard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 8 15:23:20 PDT 2022


rprichard added a comment.

I don't expect this change to affect the compiler behavior by itself -- is there a particular test that should be written?

The code that I'm moving into NVPTXTargetInfo::setAuxTarget is already tested via clang/test/Preprocessor/cuda-types.cu.

Aside: There are only two calls to AllocateTarget: one in TargetInfo::CreateTargetInfo and one in NVPTXTargetInfo::NVPTXTargetInfo. This change removes NVPTXTargetInfo's call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127267/new/

https://reviews.llvm.org/D127267



More information about the cfe-commits mailing list