[PATCH] D126891: [clang-tidy] The check should ignore final classes

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

In D126891#3554039 <https://reviews.llvm.org/D126891#3554039>, @carlosgalvezp wrote:

> Hmm, `MostDerived` **does** have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn.
>
> Seems like there's some deeper problem in the check?

Not quite. None of the destructors are virtual in the example. In fact, the `MostDerived` has a //public// and //non-virtual// destructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126891/new/

https://reviews.llvm.org/D126891