[PATCH] D126891: [clang-tidy] The check should ignore final classes

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 11:32:08 PDT 2022


carlosgalvezp added a comment.

Hmm, `MostDerived` **does** have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn.

Seems like there's some deeper problem in the check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126891/new/

https://reviews.llvm.org/D126891



More information about the cfe-commits mailing list