[PATCH] D126681: [HIP] Fix static lib name on windows

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 31 14:51:19 PDT 2022


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1788
+    for (auto Prefix : {"/libdevice/", "/"}) {
+      if (IsMSVC) {
+        AOBFileNames.push_back(Twine(LPath + Prefix + Lib + ".lib").str());
----------------
tra wrote:
> style nit: no need for braces here
> https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
will fix when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126681/new/

https://reviews.llvm.org/D126681



More information about the cfe-commits mailing list