[PATCH] D126681: [HIP] Fix static lib name on windows
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 31 10:11:49 PDT 2022
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1788
+ for (auto Prefix : {"/libdevice/", "/"}) {
+ if (IsMSVC) {
+ AOBFileNames.push_back(Twine(LPath + Prefix + Lib + ".lib").str());
----------------
style nit: no need for braces here
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126681/new/
https://reviews.llvm.org/D126681
More information about the cfe-commits
mailing list