[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

> This change in itself reduced the run-time of the analysis to 16 seconds, on my machine. However, the repetition of States should still be addressed. I am going to upload the upper patch for a starter.

Sorry, in that 16s, I measured also the rebuild and linkage of the Clang binary. The time is actually way better, 2.8s, which is quite close to the original values we had before this change. So, perhaps it is not even needed to bother with the above mentioned cache mechanism.

   time ./bin/clang --analyze -Xclang -analyzer-checker=core,alpha.security.ArrayBoundV2,debug.ExprInspection test.c
  test.c:14:3: warning: 1 [debug.ExprInspection]
    clang_analyzer_numTimesReached(); // 1 times
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  test.c:16:5: warning: 253 [debug.ExprInspection]
      clang_analyzer_numTimesReached(); // 285 times
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  test.c:21:5: warning: 805 [debug.ExprInspection]
      clang_analyzer_numTimesReached(); // 1128 times
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  test.c:24:7: warning: 487 [debug.ExprInspection]
        clang_analyzer_numTimesReached(); // 560 times
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  4 warnings generated.
  ./bin/clang --analyze -Xclang  test.c  2.74s user 0.07s system 99% cpu 2.811 total


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124758/new/

https://reviews.llvm.org/D124758