[clang] 6f4644d - [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

Martin Boehme via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 08:15:49 PDT 2022


Author: Martin Boehme
Date: 2022-05-25T17:15:41+02:00
New Revision: 6f4644d194da594562027a5d458d9fb7a20ebc39

URL: https://github.com/llvm/llvm-project/commit/6f4644d194da594562027a5d458d9fb7a20ebc39
DIFF: https://github.com/llvm/llvm-project/commit/6f4644d194da594562027a5d458d9fb7a20ebc39.diff

LOG: [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

As @rsmith commented on https://reviews.llvm.org/D111548: "That looks like it's
simply a bug as far as I can tell, and that call can be removed. MS attributes
will be parsed as part of the decl specifier sequence as needed and don't need
to be parsed as declaration attributes."

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D126062

Added: 
    

Modified: 
    clang/lib/Parse/ParseDeclCXX.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Parse/ParseDeclCXX.cpp b/clang/lib/Parse/ParseDeclCXX.cpp
index 22ad9e030b0d8..5ed989f17c1bc 100644
--- a/clang/lib/Parse/ParseDeclCXX.cpp
+++ b/clang/lib/Parse/ParseDeclCXX.cpp
@@ -438,7 +438,6 @@ Decl *Parser::ParseExportDeclaration() {
     // FIXME: Factor out a ParseExternalDeclarationWithAttrs.
     ParsedAttributes Attrs(AttrFactory);
     MaybeParseCXX11Attributes(Attrs);
-    MaybeParseMicrosoftAttributes(Attrs);
     ParseExternalDeclaration(Attrs);
     return Actions.ActOnFinishExportDecl(getCurScope(), ExportDecl,
                                          SourceLocation());
@@ -458,7 +457,6 @@ Decl *Parser::ParseExportDeclaration() {
          Tok.isNot(tok::eof)) {
     ParsedAttributes Attrs(AttrFactory);
     MaybeParseCXX11Attributes(Attrs);
-    MaybeParseMicrosoftAttributes(Attrs);
     ParseExternalDeclaration(Attrs);
   }
 


        


More information about the cfe-commits mailing list