[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 08:01:36 PDT 2022


sammccall added a comment.

The intent here is that `user-defined-string-literal-chunk := STRING_LITERAL` only matches when there's a ud-suffix. And `string-literal-chunk := STRING_LITERAL` only matches when there isn't.
(e.g. with a rule guard, which we don't have implemented)
If this was happening, would we still have the explosion?

I believe (once the guards are added) this patch will lead to rejecting "foo" "bar"_ud "baz".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125794/new/

https://reviews.llvm.org/D125794



More information about the cfe-commits mailing list