[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 07:56:14 PDT 2022


hokein added inline comments.


================
Comment at: clang-tools-extra/pseudo/lib/cxx.bnf:716
 string-literal := string-literal-chunk
-string-literal := string-literal string-literal-chunk
+string-literal := string-literal-chunk string-literal
 user-defined-literal := user-defined-integer-literal
----------------
I also wrote this as right recursive, it significantly reduces the states in the GSS (35% saving!) 

before:
```
Forest bytes: 1898128 nodes: 105456
GSS bytes: 3801192 nodes: 158029
```

after:
```
Forest bytes: 1898128 nodes: 105456
GSS bytes: 2539624 nodes: 105433
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125794/new/

https://reviews.llvm.org/D125794



More information about the cfe-commits mailing list