[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1
+// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t
+
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > Consider adding a test:
> > 
> > ```
> > // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp < %s
> > ```
> > 
> > I don't think you need `-S` here or `-o %t` since there should be nothing produced from -fsyntax-only.
> Sorry, I missed a `-` for "read from stdin":
> ```
> // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp - < %s
> ```
Sorry, I meant for you to have two run lines. One that specified `-x assembler-with-cpp` and one without. But I think `-x assembler-with-cpp` is not necessary, you should/can/may drop it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125727/new/

https://reviews.llvm.org/D125727