[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

Ken Matsui via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 16 15:00:19 PDT 2022


ken-matsui added inline comments.


================
Comment at: clang/lib/Lex/PPDirectives.cpp:484
                                           const SourceLocation &EndLoc) const {
+  // If this is a `.S` file, treat unknown # directives as non-preprocessor
+  // directives.
----------------
nickdesaulniers wrote:
> Also, IIRC the token used to start a comment in assembler differs per architecture. This might be the simplest fix, for now.
Ah, I did not know that. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125727/new/

https://reviews.llvm.org/D125727



More information about the cfe-commits mailing list