[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

Wed May 11 03:57:53 PDT 2022

aaron.ballman added a comment.

In D124534#3505709 <https://reviews.llvm.org/D124534#3505709>, @aaron.ballman wrote:

> In D124534#3504641 <https://reviews.llvm.org/D124534#3504641>, @ken-matsui wrote:
>
>> (I use this info for every commit on GitHub, but is this what you expected? Please let me know if you need an email where you can be reached out.)
>
> That looks to be exactly what I needed, but you can double-check that you were properly attributed here: https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf

Actually, it does raise an interesting issue -- I don't think you'll get build failure emails when using that address. After a patch is landed, a bunch of build bots test the patch out and when there's a failure, they send email to everyone on the blame list. You should probably use an email address that receives email for future commits (or when you go to obtain your own commit privileges) so that you can receive those emails.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124534/new/

https://reviews.llvm.org/D124534