[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

Wed May 11 03:46:55 PDT 2022

aaron.ballman added a comment.

In D124534#3504641 <https://reviews.llvm.org/D124534#3504641>, @ken-matsui wrote:

> In D124534#3504610 <https://reviews.llvm.org/D124534#3504610>, @aaron.ballman wrote:
>
>> LGTM, thank you for all the hard work on this! I assume you need me to land this on your behalf -- if so, can you let me know what name and email address you would like me to use for patch attribution?
>
> Thank you so much for your support and approval!

Happy to help!

> Yes, I do not have commit access; could you please use the following info for this patch?
>
> Name: Ken Matsui
> Email: 26405363+ken-matsui at users.noreply.github.com
>
> (I use this info for every commit on GitHub, but is this what you expected? Please let me know if you need an email where you can be reached out.)

That looks to be exactly what I needed, but you can double-check that you were properly attributed here: https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf

>> I think we should add a release note for this to let folks know about the new warning group (there's a "Improvements to Clang's diagnostics" in clang/docs/ReleaseNotes.rst). You can either add one to this patch, or I can add one for you when I go to land, I'm fine either way.
>
> Could you please add it to this patch for this time?
> I would like to add one next time by referring to how you do.

I added one when I landed. I also adjusted the commit message slightly from what you have here in Phab for some added clarity.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124534/new/

https://reviews.llvm.org/D124534