[PATCH] D124983: [HLSL} add -fcgl option flag.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6765
          "as_6_5, as_6_6, as_6_7">;
+def fcgl : DXCFlag<"fcgl">,
+  HelpText<"Generate high-level code only. Without any dxil related passes.">;
----------------
aaron.ballman wrote:
> Any particular reason for this name? Naively, I have no idea what this does or how it relates to code generation.
I have no idea what this name is short for… code gen language?… likeness?… lobotomy?…

We have this flag in DXC, and it is a useful shorthand.

Don’t know if @python3kgae or @pow2clk know what the actual abbreviation is.


================
Comment at: clang/include/clang/Driver/Options.td:6766
+def fcgl : DXCFlag<"fcgl">,
+  HelpText<"Generate high-level code only. Without any dxil related passes.">;
----------------
aaron.ballman wrote:
> 
This really has nothing to do with DXIL as a target, and will apply to any HLSL target out of clang. A more accurate description might be that it disables all optimization and code generation passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124983/new/

https://reviews.llvm.org/D124983