[PATCH] D124983: [HLSL} add -fcgl option flag.

Thu May 5 05:01:58 PDT 2022

aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:6765
          "as_6_5, as_6_6, as_6_7">;
+def fcgl : DXCFlag<"fcgl">,
+  HelpText<"Generate high-level code only. Without any dxil related passes.">;
----------------
Any particular reason for this name? Naively, I have no idea what this does or how it relates to code generation.

================
Comment at: clang/include/clang/Driver/Options.td:6766
+def fcgl : DXCFlag<"fcgl">,
+  HelpText<"Generate high-level code only. Without any dxil related passes.">;
----------------

================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:613

+TEST(DxcModeTest, ValidatorFCGL) {
+  IntrusiveRefCntPtr<DiagnosticIDs> DiagID(new DiagnosticIDs());
----------------
Any reason not to use the typical lit tests for this? It seems like you should be able to add a Driver test that does `-###` and looks for the expected pass-down flags. And then you can add a -cc1 test to ensure that the `-fcgl` flag isn't supported there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124983/new/

https://reviews.llvm.org/D124983