[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

Digger Lin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 10:56:29 PDT 2022


DiggerLin marked 8 inline comments as done.
DiggerLin added inline comments.


================
Comment at: clang/test/Driver/aix-ld.c:985
+// CHECK-LD64-SHARED-EXPFULL:     "-bM:SRE"
+// CHECK-LD64-SHARED-EXPFULL:     "-bnoentry"
+// CHECK-LD64-SHARED-EXPFULL:     "-b64"
----------------
MaskRay wrote:
> If these options are actually adjacent, check them on the same line to make the test more strict: you can catch issues if new options are somehow inserted in between.
yes, the options are actually adjacent now, if we put these option in the same line,  there maybe a failure when the driver change the options(for example adding a option) later.  and it will have different style on the existing test options


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119147/new/

https://reviews.llvm.org/D119147



More information about the cfe-commits mailing list