[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

[Digger Lin via Phabricator via cfe-commits]

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: clang/test/Driver/aix-ld.c:675-676
+// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm"
+// CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
+// CHECK-LD32-SHARED-EXPORTS-NOT: "32"
+// CHECK-LD32-SHARED-EXPORTS:     "{{.*}}ld{{(.exe)?}}"
----------------
stevewan wrote:
> And please keep this consistent across the tests.
using:
// CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
// CHECK-LD32-SHARED-EXPORTS-NOT: "32"

will be fail on the -X 64 too.

using  // CHECK-LD32-SHARED-EXPORTS-NOT: "-X" "32"
 will be success on the -X 64. 
So I am prefer use the
 CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
 CHECK-LD32-SHARED-EXPORTS-NOT: "32" 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119147/new/

https://reviews.llvm.org/D119147