[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

[Argyrios Kyrtzidis via Phabricator via cfe-commits]

akyrtzi added a comment.

In D124687#3485710 <https://reviews.llvm.org/D124687#3485710>, @tschuett wrote:

> Could you split this into smaller patches?

I'll split up the renames to a separate patch so that it is easier to see the code that affects functionality. Not sure if it can be broken further, after that the changes are interdependent.
Once I separate the renames we can see how it looks, I suspect it will be much easier to review.

> Does this support C++20 modules or is it limited to clang header modules?

Dependency scanning should work the same as before for C++20 modules, there should not be a change (either making it worse or better).

> Is there overhead in the non dependency scanning mode?

Good suggestion, I'll do some measurements and get back to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124687/new/

https://reviews.llvm.org/D124687