[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

Mon May 2 12:16:36 PDT 2022

akyrtzi added inline comments.

================
Comment at: clang/include/clang/Lex/PreprocessorOptions.h:214
+      FileEntryRef)>
+      DependencyDirectivesForFile;

----------------
jansvoboda11 wrote:
> To be honest, I'm not a fan of using `PreprocessorOptions` to carry state between compiler invocations.
> 
> Could we implement a different mechanism for this in a prep patch an put `DependencyDirectivesForFile` there? `FailedModules` also seem as a state rather than options.
Would you be ok to consider this as a task for follow-up? It seems orthogonal to the intended changes of this patch (I mean the patch doesn't make things worse in that respect AFAICT)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124687/new/

https://reviews.llvm.org/D124687