[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

Mon May 2 01:27:54 PDT 2022

sammccall added a comment.

In D124688#3485042 <https://reviews.llvm.org/D124688#3485042>, @nridge wrote:

> In D124688#3483895 <https://reviews.llvm.org/D124688#3483895>, @sammccall wrote:
>
>> Trying this on a few files, this seems like it increases preamble sizes up to 1% or so
>
> Are preamble sizes a good proxy for preamble build times as well? I suspect that may be the metric that's more noticeable for users.

Agree, yes I **think** they're a pretty good proxy for this sort of change which parses more/less code. (Preamble size more or less counting AST nodes).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124688/new/

https://reviews.llvm.org/D124688