[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 01:16:36 PDT 2022


ilya-biryukov added a comment.

In D124606#3484740 <https://reviews.llvm.org/D124606#3484740>, @Meinersbur wrote:

> In D124606#3479793 <https://reviews.llvm.org/D124606#3479793>, @ilya-biryukov wrote:
>
>> LGTM
>
> This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 <https://reviews.llvm.org/D124563> and D97625 <https://reviews.llvm.org/D97625> to react, and should have been added as reviewers. I didn't even see @ilya-biryukov participating in the other discussions.

We committed this to unbreak our internal integrate at Google. Integrates are time-critical for us, so we normally choose to unbreak early and have post-commit discussions instead.
We should have probably communicated this better in commit messages and reviews.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124606/new/

https://reviews.llvm.org/D124606



More information about the cfe-commits mailing list