[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 07:05:07 PDT 2022

aaronpuchert added subscribers: smeenai, aaronpuchert.
aaronpuchert added a comment.

I think this change broke again what D97625 <https://reviews.llvm.org/D97625> was trying to fix. These are text files and we want them to keep the specified line endings regardless of the local git configuration. See also @smeenai's comment D124563#3478625 <https://reviews.llvm.org/D124563#3478625>.

Comment at: clang-tools-extra/test/.gitattributes:7-15
+clang-apply-replacements/ClangRenameClassReplacements.cpp -text
+clang-apply-replacements/Inputs/basic/basic.h -text
+clang-apply-replacements/Inputs/format/no.cpp -text
+clang-apply-replacements/Inputs/format/yes.cpp -text
+clang-tidy/infrastructure/export-diagnostics.cpp -text
 # These test input files rely on two-byte Windows (CRLF) line endings.
My understanding is that `-text` removes an attribute, but what attribute is there to remove? There is no global `.gitattributes` that would set it in the first place. This change just reverts to the status quo before D97625, or rather before that file was moved.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list