[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 07:46:14 PDT 2022


adamcz accepted this revision.
adamcz added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:373
+  }
+  llvm::StringRef filePath() const { return File->getFilePath(); }
+  llvm::StringRef memoryContents() const { return *Memory; }
----------------
Maybe add asserts here and below to check that Kind is indeed File or Memory?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124177/new/

https://reviews.llvm.org/D124177



More information about the cfe-commits mailing list