[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 07:37:16 PDT 2022

sammccall created this revision.
sammccall added a reviewer: adamcz.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

- Remove fiddly union, preambles are heavyweight
- Remove fiddly move constructors in TempPCHFile and PCHStorage, use unique_ptr
- Remove unneccesary accessors on PCHStorage
- Remove trivial InMemoryStorage
- Move implementation details into cpp file

This is a prefactoring, followup change will change the in-memory PCHStorage to
avoid extra string copies while creating it.

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124177.424202.patch
Type: text/x-patch
Size: 17289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220421/59b03188/attachment.bin>

More information about the cfe-commits mailing list