[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Qiongsi Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 14 19:20:08 PDT 2022


qiongsiwu1 updated this revision to Diff 422996.
qiongsiwu1 added a comment.

> Also, what's the feedback mechanism for issues with these listings? Say we add a new Arm header but forget to put it on these lists, who would be the first to notice? (I admit I'm not very familiar with the process of distributions)

Ok so I reworked the logic to add the generated headers and added a check. If there is a header generated, but not added to a target specific list, we have a cmake warning during configuration. The reason that I did not make it into a fatal error is that the omission does not affect building and testing clang/llvm, and it only affects a target specific distribution target. I can revise it to a fatal error if that is more desired.

Thanks again @DavidSpickett for the feedback! @chill may I get some comments from you as well? Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123498/new/

https://reviews.llvm.org/D123498

Files:
  clang/lib/Headers/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123498.422996.patch
Type: text/x-patch
Size: 14282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220415/45d29f8a/attachment-0001.bin>


More information about the cfe-commits mailing list