[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

[Qiongsi Wu via Phabricator via cfe-commits]

qiongsiwu1 updated this revision to Diff 422959.
qiongsiwu1 added a comment.

Thanks @DavidSpickett !! The patch is updated. The `arm` headers are now split between `arm` and `aarch64`.

> Also, what's the feedback mechanism for issues with these listings? Say we add a new Arm header but forget to put it on these lists, who would be the first to notice? (I admit I'm not very familiar with the process of distributions)

This is a good question. I don't think there are automatic tests against distribution installations. So in the worst case it could be the user of a distribution to first notice that a header is missing. Let me look into the possibilities to automatically check for the case if a header exists, but is not added to any of the target specific headers.

At the moment, adding new `arm` specific headers to `arm_common_files`, `arm_only_files` or `aarch64_only_files` lists will make sure they are included in the distribution targets. The generated ones are more problematic and may be missed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123498/new/

https://reviews.llvm.org/D123498

Files:
  clang/lib/Headers/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123498.422959.patch
Type: text/x-patch
Size: 12947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220414/ebb9d58d/attachment-0001.bin>