[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 14 11:18:01 PDT 2022


efriedma added a comment.

In D123627#3451373 <https://reviews.llvm.org/D123627#3451373>, @aaron.ballman wrote:

> Thank you for letting me know -- I've speculatively fixed the issue in 726901d06aab2f92d684d28507711308368c29d6 <https://reviews.llvm.org/rT726901d06aab2f92d684d28507711308368c29d6>

Can you also look into improving the error message?  Just saying "conflicting types for 'rintf'", with a note saying the previous declaration is at the exact same location, is going to confuse anyone who writes `float rintf(){}`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123627/new/

https://reviews.llvm.org/D123627



More information about the cfe-commits mailing list